pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Make publish topic for pps posttroll hook patternable #30

Closed mraspaud closed 2 years ago

mraspaud commented 2 years ago

This PR allows the publish topic of pps posttroll hook to be a pattern which will be filled with some metadata.

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (e271c64) into main (a622f50) will increase coverage by 0.27%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   48.96%   49.24%   +0.27%     
==========================================
  Files          14       14              
  Lines        1640     1649       +9     
  Branches      216      213       -3     
==========================================
+ Hits          803      812       +9     
  Misses        825      825              
  Partials       12       12              
Flag Coverage Δ
unittests 49.24% <100.00%> (+0.27%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/pps_posttroll_hook.py 77.10% <100.00%> (-0.14%) :arrow_down:
nwcsafpps_runner/tests/test_pps_hook.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a622f50...e271c64. Read the comment docs.

adybbroe commented 2 years ago

For me the decrease in coverage is neglible - as far I can see you have added the kind of testing necessary for the refactoring