Use orbit number from message.

[TAlonglong]

Use orbit number from message if configured.

Else hardcoded value in the initialiser is used which may cause problems in downstream processing eg. pps-runner.

• [X] Closes #41
• [X] Tests added
• [X] Tests passed: Passes pytest nwcsafpps_runner
• [X] Passes flake8 nwcsafpps_runner
• [ ] Fully documented

[codecov[bot]]

Codecov Report

Merging #42 (f174707) into main (9a13adc) will increase coverage by 2.95%. The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   53.94%   56.90%   +2.95%     
==========================================
  Files          14       14              
  Lines        1774     1884     +110     
  Branches      213      243      +30     
==========================================
+ Hits          957     1072     +115     
+ Misses        799      790       -9     
- Partials       18       22       +4     

Flag	Coverage Δ
unittests	56.90% <97.72%> (+2.95%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nwcsafpps_runner/l1c_processing.py	73.87% <80.00%> (+9.72%)	:arrow_up:
nwcsafpps_runner/tests/test_level1c_runner.py	99.47% <100.00%> (+0.10%)	:arrow_up:
nwcsafpps_runner/metno_update_nwp.py	0.00% <0.00%> (ø)
nwcsafpps_runner/tests/test_pps_hook.py	100.00% <0.00%> (ø)
nwcsafpps_runner/pps_posttroll_hook.py	81.03% <0.00%> (+3.92%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a13adc...f174707. Read the comment docs.

[TAlonglong]

No, it means you have to add a configure option. https://github.com/pytroll/pytroll-pps-runner/pull/42/commits/0e93677fdb79050063dde23536cc51dc9c952d02#diff-5acabd14fe6912227fe024fd41a204b1cc1ad07a1bc220050edf3282eb110907R80

But I have just figured out this does not work as the level1c4pps software does not respect any input. So it will require a major addition to level1c4pps to work which I will not do.

I accept that the orbit number is hardcoded to 00000

[pnuu]

Oh, ok. Then I would've asked to add the required config option to the examples, but if it isn't respected in any case :man_shrugging: