pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Fix nwp prepare #52

Closed ninahakansson closed 1 year ago

ninahakansson commented 2 years ago

Be smarter when constructing the NWP files for PPS. Only include fields from the requirement file. Also don't use the name of fields as that can be slightly modified (Height => height).

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (bea4f0c) into main (d1ed092) will increase coverage by 7.94%. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   58.41%   66.36%   +7.94%     
==========================================
  Files          14       15       +1     
  Lines        1960     2066     +106     
  Branches      248      323      +75     
==========================================
+ Hits         1145     1371     +226     
+ Misses        793      656     -137     
- Partials       22       39      +17     
Flag Coverage Δ
unittests 66.36% <94.73%> (+7.94%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/tests/test_nwp_prepare.py 94.66% <94.66%> (ø)
nwcsafpps_runner/prepare_nwp.py 71.13% <94.82%> (+71.13%) :arrow_up:
nwcsafpps_runner/tests/test_utils.py 100.00% <0.00%> (ø)
nwcsafpps_runner/publish_and_listen.py 0.00% <0.00%> (ø)
nwcsafpps_runner/utils.py 37.10% <0.00%> (+3.46%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adybbroe commented 2 years ago

Is it ready for review @ninahakansson ? I see the test coverage went down a bit?

ninahakansson commented 1 year ago

I fixed most of the comments.

adybbroe commented 1 year ago

@TAlonglong Could you have a quick look as well. I am quite happy and ready to merge now. Once we understand the failed tests above

adybbroe commented 1 year ago

@ninahakansson https://conda-forge.org/docs/user/announcements.html#dropping-python-3-7 Time to drop 3.7 support? Otherwise we need to find another channel to get Python 3.7