pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Fix find xml from l1c #54

Closed ninahakansson closed 1 year ago

ninahakansson commented 1 year ago

For PPSv2021 when we have the level1c file, all other files produced by PPS can be derived from it. Use the level1c file to find the xml files.

codecov[bot] commented 1 year ago

Codecov Report

Merging #54 (6b2b22d) into main (f72b52d) will increase coverage by 1.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   66.39%   67.44%   +1.05%     
==========================================
  Files          15       15              
  Lines        2074     2141      +67     
  Branches      292      292              
==========================================
+ Hits         1377     1444      +67     
  Misses        658      658              
  Partials       39       39              
Flag Coverage Δ
unittests 67.44% <100.00%> (+1.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/tests/test_utils.py 100.00% <100.00%> (ø)
nwcsafpps_runner/utils.py 39.69% <100.00%> (+2.59%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ninahakansson commented 1 year ago

When I click on details for the failed coveralls -run I see different numbers: coverage increased (+0.7%) to 64.351%. I don't understand what it is unhappy about?

adybbroe commented 1 year ago

When I click on details for the failed coveralls -run I see different numbers: coverage increased (+0.7%) to 64.351%. I don't understand what it is unhappy about?

Don't know either, I have had trouble with understanding the Coveralls results in other projects recently. I am happy with CodeFactor that also checks test coverage:

https://app.codecov.io/gh/pytroll/pytroll-pps-runner/pull/54