pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Fix avhrr #57

Closed ninahakansson closed 1 year ago

ninahakansson commented 1 year ago

Adapt the runner to PPS-v2021 with level1c processing done by level1c4pps also for AVHRR and MODIS. This inlcudes fixes for trollflow2 > 0.14.0. We no longer ssh to the uri's as we are using local files. The ssh-info was before removed with urlparse by trollflow2 and it is no longer removed by default. So better to not add it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #57 (c7214fd) into main (5deea6f) will increase coverage by 1.95%. The diff coverage is 79.06%.

:exclamation: Current head c7214fd differs from pull request most recent head 52e7b6a. Consider uploading reports for the commit 52e7b6a to get more accurate results

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   68.66%   70.62%   +1.95%     
==========================================
  Files          15       15              
  Lines        2170     2192      +22     
  Branches      293      293              
==========================================
+ Hits         1490     1548      +58     
+ Misses        642      602      -40     
- Partials       38       42       +4     
Flag Coverage Δ
unittests 70.62% <79.06%> (+1.95%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/utils.py 50.64% <22.22%> (+6.65%) :arrow_up:
nwcsafpps_runner/l1c_processing.py 71.77% <33.33%> (-2.63%) :arrow_down:
nwcsafpps_runner/message_utils.py 80.00% <100.00%> (+2.58%) :arrow_up:
nwcsafpps_runner/pps_posttroll_hook.py 85.05% <100.00%> (+4.02%) :arrow_up:
nwcsafpps_runner/tests/test_level1c_runner.py 98.96% <100.00%> (ø)
nwcsafpps_runner/tests/test_pps_hook.py 100.00% <100.00%> (ø)
nwcsafpps_runner/tests/test_utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adybbroe commented 1 year ago
  • [ ] Closes #xxxx

    • [x] Tests added

    • [x] Tests passed: Passes pytest nwcsafpps_runner

    • [x] Passes flake8 nwcsafpps_runner

    • [ ] Fully documented

Could you please drop a couple of lines on the purpose and motivation for this PR ? "Fix avhrr" is not very helpful.