search

pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

PPS 2021 refactor #60

Closed ninahakansson closed 4 months ago

ninahakansson commented 7 months ago

Update the code to support only PPS-2021 and drop support for PPS 2014. The main thing is that the pps runner need only the level1c file to run. The NWP preparation is now in a separate runner. Some refactoring, with more subroutines in prepare_nwp

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 74.02597% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 74.24%. Comparing base (fc4314d) to head (5354d27).

:exclamation: Current head 5354d27 differs from pull request most recent head c977117. Consider uploading reports for the commit c977117 to get more accurate results

Files Patch % Lines
nwcsafpps_runner/prepare_nwp.py 64.70% 31 Missing and 11 partials :warning:
nwcsafpps_runner/message_utils.py 11.11% 8 Missing :warning:
nwcsafpps_runner/utils.py 78.12% 5 Missing and 2 partials :warning:
nwcsafpps_runner/config.py 82.35% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 70.55% 74.24% +3.68% ========================================== Files 15 15 Lines 2201 1778 -423 Branches 296 266 -30 ========================================== - Hits 1553 1320 -233 + Misses 606 419 -187 + Partials 42 39 -3 ``` | [Flag](https://app.codecov.io/gh/pytroll/pytroll-pps-runner/pull/60/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pytroll-pps-runner/pull/60/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `74.24% <74.02%> (+3.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ninahakansson commented 6 months ago

Thanks for the comments @pnuu! The pps_runner.py was for version 2014 only. The pps2018_runner.py was for version 2018 and forward. I can rename the pps2018_runner.py to pps_runner.py as there is now only one runner. I will have a look at the config files too.