Fix nasa ftp retrieval - Githubissues

pytroll / pytroll-schedule

Reception scheduling of polar weather satellites

http://pytroll-schedule.readthedocs.org/

GNU General Public License v3.0

9 stars 12 forks source link

Fix nasa ftp retrieval #41

Closed adybbroe closed 5 years ago

adybbroe commented 5 years ago

NASA has changed to no longer support plain FTP access for reasons of security. Only FTPS or HTTPS is now supported by these servers.

Now we use ftplib.FTP_TLS instead of ftplib.FTP to connect to the nasa server in order to download Aqua/Terra downlink schedules

This PR also fixes and improves a few other issues:

Get rid of Satpy dependency
Fix for latest Pyresample
Add stickler checks
Use six module to sole urlparse imports instead of try-except solution
[ ] Closes #xxxx
[ ] Tests added
[x] Tests passed
[x] Passes git diff origin/master **/*py | flake8 --diff
[ ] Fully documented

coveralls commented 5 years ago

Coverage decreased (-0.06%) to 38.373% when pulling b597ca2bb215c42582f178a4ea3592b116f279a7 on adybbroe:fix-nasa-ftp-retrieval into 9b594a35c74a12c895a7957565929b994f15f8fd on pytroll:master.

adybbroe commented 5 years ago

Well, my simple change from "FTP" to "FTP_TLS" was too simple, I will be back....

adybbroe commented 5 years ago

Ok, now I think we are ok

adybbroe commented 5 years ago

Can we please merge this @pnuu and @mraspaud ?

adybbroe commented 5 years ago

Sorry, wait, I think there is something I can improve...

adybbroe commented 5 years ago

Ok, ready. Can I merge @pnuu ?

pnuu commented 5 years ago

If it works, why not. I don't use this feature myself, so can't test.