pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.08k stars 298 forks source link

malfunctioning night_microphysics composite for VIIRS #1660

Open hproe opened 3 years ago

hproe commented 3 years ago

A VIIRS composite 'night_microphysics' is defined in 'VIIRS.yaml' on the composite side (DNB, M12, M15), but there is no corresponding enhancement found in the 'VIIRS.yaml' on the enhancement side. Satpy defaults to 'generic.yaml', where 'night_microphysics_default' is found. However, this enhancement does not consider the DNB band and produces nonsense.

I propose to add the correct enhancement in the 'VIIRS.yaml' on the enhancement side.

While the idea of having generic composites is attractive for some reasons, I suggest that for sensor-specific composites both, the band selection and the enhancement part, should be explicitly defined in the relative sensor.yaml. Taking this further, this leads to consider a second species of composite yaml files, where band selection and enhancement fused into one block, while retaining the existing split configurations for backward compatibility. I agree, not an easy task.

gerritholl commented 2 years ago

This is what our VIIRS night_microphysics RGB looks like for an overpass 2022-01-10 00:59-01:15:

Suomi-NPP-night_microphysics-dwd_germany_wgs84-20220110_0059-0115-geotiff-0