Closed djhoese closed 5 months ago
@djhoese. A good test data set is here: bumi:/data/users/kathys/test_data/viirs_edr/j01/summer/asci/
.
See image here: https://github.com/ssec/polar2grid/issues/666
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
afb4049
) 95.39% compared to head (9d8b2fd
) 95.40%. Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
Totals | |
---|---|
Change from base Build 7416976545: | 0.005% |
Covered Lines: | 50449 |
Relevant Lines: | 52572 |
@mraspaud I commented on your question. Otherwise I think this is ready to go with the small fix I just committed.
Polar2Grid PR: https://github.com/ssec/polar2grid/pull/674
See https://github.com/ssec/polar2grid/issues/666 for more information. Basically the AOD ("AOD550") product from the VIIRS EDR files looks a little "not good" by default. @kathys and I would like to play around with filtering it based on the
QCAll
QC variable in the file.@kathys I think as a starting point maybe you could point me to some data files of a good test case and I could generate images for all of the QC cases (0, 1, 2, 3 - default) and we see which looks best. I don't think it necessarily matters what Satpy uses in this PR as I've turned it off by default with the general practice Satpy has of not interfering with data coming from the files.