pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.04k stars 287 forks source link

Fix nominal time attributes in SEVIRI HRIT #2743

Closed sfinkens closed 4 months ago

sfinkens commented 4 months ago

Fix nominal_start/end_time attributes in SEVIRI HRIT, which were tuples due to a trailing comma.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4877082) 95.88% compared to head (f8937d4) 95.89%. Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2743 +/- ## ======================================= Coverage 95.88% 95.89% ======================================= Files 371 371 Lines 52825 52825 ======================================= + Hits 50653 50656 +3 + Misses 2172 2169 -3 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2743/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2743/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.15% <33.33%> (ø)` | | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2743/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `95.99% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7901641731

Details


Totals Coverage Status
Change from base Build 7801990864: 96.0%
Covered Lines: 50528
Relevant Lines: 52648

💛 - Coveralls
djhoese commented 4 months ago

Someone more involved in SEVIRI reader development (including @sfinkens) can merge this. I don't feel comfortable doing it.