Closed pnuu closed 6 months ago
Any ideas what would be the best way to adapt the tests to check for both attribute versions? Dupplicating the fake filehandler class and the test class doesn't seem very attractive...
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.92%. Comparing base (
85d9117
) to head (2fff0d4
). Report is 34 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok, duplicated the minimal amount of test code I thought was necessary.
Totals | |
---|---|
Change from base Build 8205996229: | 0.003% |
Covered Lines: | 51193 |
Relevant Lines: | 53325 |
CC @wjsharpe, Does this look good to you?
Posting the realization from slack here for the record: @pnuu was using the old "viirs_l2.py" reader that he had created a while ago. A couple months ago I reworked all the VIIRS EDR (note EDR, not L2) to be one viirs_edr
reader. The new VIIRS L2 reader being modified here is from #2740 by @wjsharpe and is for the NASA VIIRS L2 products not the NOAA EDR products.
Looks good to me
I should've remembered that viirs_l2
-> viirs_edr
change. I'll test the v3r2 and v3r0 files tomorrow with the current Satpy and close this if both already work.
Yeah, this PR was a mixup with the old viirs_l2.py
and the current viirs_edr.py
for the ASCI files. Closing, viirs_edr
already works with both of the versions I have.
The some of the attributes in the CSPP/ASCI files have been renamed between v3r0 and v3r2. The only on I've seen that affects Satpy is the instrument name. The original reader version was based on older data and works at least until v3r0 files, but the current one seems to handle only the newer files. With this PR both can be read.
AUTHORS.md
if not there already