pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.06k stars 292 forks source link

Add new (Eumetrain) FCI RGB composites #2780

Closed ameraner closed 5 months ago

ameraner commented 5 months ago

This PR adds a series of RGB composites for FCI. In most cases, the new RGBs reuse existing recipes, and will have to be tuned further to account for the specific FCI properties (SRF, resolution, etc).

It adds the composites:

By doing this, it contributes in several ways to https://github.com/pytroll/satpy/issues/2670. To close that issue, we still need to sort out a few midlatitude/tropical recipes: since this affects many shared recipes and is not specific to FCI, I would leave that to a different PR.

After this PR, the list of available composites for FCI becomes:

24h_microphysics
airmass
ash
cimss_cloud_type
cimss_cloud_type_raw
cloud_phase
cloud_phase_distinction
cloud_phase_distinction_raw
cloud_phase_raw
cloud_phase_with_night_ir105
cloud_type
cloud_type_with_night_ir105
cloudtop
colorized_ir_clouds
convection
day_essl_colorized_low_level_moisture
day_essl_low_level_moisture
day_microphysics
dust
essl_colorized_low_level_moisture
essl_low_level_moisture
fire_temperature
fire_temperature_38refl
fire_temperature_rad
fog
geo_color
geo_color_background_with_low_clouds
geo_color_high_clouds
geo_color_low_clouds
geo_color_night
green_snow
ir108_3d
ir_cloud_day
ir_sandwich
ir_sandwich_with_night_colorized_ir_clouds
natural_color
natural_color_raw
ndvi_hybrid_green
ndvi_hybrid_green_fully_sunzencorrected
ndvi_hybrid_green_raw
night_fog
night_ir105
night_ir_alpha
night_ir_with_background
night_ir_with_background_hires
night_microphysics
rocket_plume_day
rocket_plume_night
snow
true_color
true_color_fully_sunzencorrected
true_color_raw
true_color_raw_with_corrected_green
true_color_reproduction
true_color_reproduction_corr
true_color_reproduction_uncorr
true_color_with_night_ir
true_color_with_night_ir105
true_color_with_night_ir_hires

A gallery of the new RGBs: cloud_phase MTG-I1_FCI_cloud-phase_mtg_fci_fdss_6km_mpl_20231015T153000 cloud_phase_with_night_ir105 MTG-I1_FCI_cloud-phase-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000 cloud_type MTG-I1_FCI_cloud-type_mtg_fci_fdss_6km_mpl_20231015T153000 cloud_type_with_night_ir105 MTG-I1_FCI_cloud-type-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000 true_color_with_night_ir105 MTG-I1_FCI_true-color-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000 true_color_with_night_ir platform_FCI_true-color-with-night-ir_mtg_fci_fdss_6km_mpl_20231015T153000 ir_sandwich MTG-I1_FCI_ir-sandwich_mtg_fci_fdss_6km_mpl_20231015T153000 colorized_ir_clouds MTG-I1_FCI_colorized-ir-clouds_mtg_fci_fdss_6km_mpl_20231015T153000 ir_sandwich_with_night_colorized_ir_clouds MTG-I1_FCI_ir-sandwich-with-night-colorized-ir-clouds_mtg_fci_fdss_6km_mpl_20231015T153000 fire_temperature MTG-I1_FCI_fire-temperature_mtg_fci_fdss_6km_mpl_20231015T153000 fire_temperature_38refl MTG-I1_FCI_fire-temperature-38refl_mtg_fci_fdss_6km_mpl_20231015T153000 fire_temperature_rad MTG-I1_FCI_fire-temperature-rad_mtg_fci_fdss_6km_mpl_20231015T153000 snow MTG-I1_FCI_snow_mtg_fci_fdss_6km_mpl_20231015T153000 24h_microphysics MTG-I1_FCI_24h-microphysics_mtg_fci_fdss_6km_mpl_20231015T153000

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.90%. Comparing base (24109a1) to head (20fd4c1). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2780 +/- ## ========================================== - Coverage 95.92% 95.90% -0.03% ========================================== Files 377 377 Lines 53535 53535 ========================================== - Hits 51356 51345 -11 - Misses 2179 2190 +11 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2780/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.10% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.00% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simonrp84 commented 5 months ago

Thanks for adding these! Just a note for now: The example image for the day/night blend with night lights background has the wrong name in the caption I think.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8691804714

Details


Totals Coverage Status
Change from base Build 8626996485: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls
ameraner commented 5 months ago

Thanks for adding these! Just a note for now: The example image for the day/night blend with night lights background has the wrong name in the caption I think.

Ah, indeed, thanks for noticing - our plotting tool uses the standard_name, which for composites does not always work well.. will need to fix :) (cc @strandgren ). I've added the correct composite name as text in the PR description.