pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.06k stars 292 forks source link

Add a read-only FSFile.fs property #2832

Closed pnuu closed 3 months ago

pnuu commented 3 months ago

This PR exposes the private FSFile._fs via a read-only property which would be nicer than accessing the private attribute. I'll need this for using fsspec caching I'm adding to Trollflow2 in https://github.com/pytroll/trollflow2/pull/205

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.94%. Comparing base (aff4f31) to head (52953f6). Report is 332 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2832 +/- ## ======================================= Coverage 95.94% 95.94% ======================================= Files 366 366 Lines 53522 53531 +9 ======================================= + Hits 51350 51359 +9 Misses 2172 2172 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2832/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2832/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.04% <18.18%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2832/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.03% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9584991230

Details


Totals Coverage Status
Change from base Build 9520945640: 0.001%
Covered Lines: 51572
Relevant Lines: 53698

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9592336810

Details


Totals Coverage Status
Change from base Build 9588363290: 0.001%
Covered Lines: 51588
Relevant Lines: 53714

💛 - Coveralls