pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.04k stars 287 forks source link

Fix DayNightCompositor compatibility with numpy 2 #2835

Closed djhoese closed 4 days ago

djhoese commented 1 week ago

Requires https://github.com/pytroll/pyorbital/pull/155 to be fully fixed as far as the DayNightCompositor goes. I mentioned it on slack, but basically np.some_func(float) with numpy 2 will always produce a numpy.float64. Any future calculations with that result will then upcast/promote to numpy.float64 even if there are 32-bit float arrays.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.94%. Comparing base (ad353f0) to head (9339a7f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2835 +/- ## ========================================== + Coverage 95.78% 95.94% +0.15% ========================================== Files 366 366 Lines 53507 53543 +36 ========================================== + Hits 51252 51371 +119 + Misses 2255 2172 -83 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.04% <0.00%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.04% <100.00%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.