search

pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.06k stars 292 forks source link

Fix gcps type for newer rioxarray versions #2837

Closed mraspaud closed 3 months ago

mraspaud commented 3 months ago

This PR introduces a fix for the backwards incompatibility introduced in https://github.com/corteva/rioxarray/pull/787, and thus should make the tests for SAR pass again.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (2bd607a) to head (ad353f0). Report is 349 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/sar_c_safe.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2837 +/- ## ========================================== - Coverage 95.78% 95.78% -0.01% ========================================== Files 366 366 Lines 53521 53507 -14 ========================================== - Hits 51267 51252 -15 - Misses 2254 2255 +1 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2837/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2837/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.04% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2837/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `95.88% <87.50%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mraspaud commented 3 months ago

This is marked as enhancement, should it be bug fix? It is a "compatibility" fix technically right?

I was seeing it as an enhancement as it is not a bug in satpy... but I'm not picky, bug works if you prefer it.

djhoese commented 3 months ago

Yeah it could be seen either way. I guess it depends what you want it released as.