pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.06k stars 292 forks source link

Add MERSI3 / FY3F support. #2838

Closed simonrp84 closed 2 months ago

simonrp84 commented 3 months ago

This PR adds support for the MERSI-3 instrument aboard FY-3F. There's no code changes required, as the existing MERSI-2 code can be used, so only new YAML files are added.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.95%. Comparing base (53b10be) to head (1832175). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2838 +/- ## ======================================= Coverage 95.95% 95.95% ======================================= Files 366 366 Lines 53615 53615 ======================================= Hits 51446 51446 Misses 2169 2169 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2838/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2838/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `4.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2838/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.05% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yukaribbba commented 2 months ago

You forgot to change the filetype name from mersi2 to mersi3...

simonrp84 commented 2 months ago

You forgot to change the filetype name from mersi2 to mersi3...

Haha, well spotted - fixed now. Thanks @yukaribbba!

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10002879545

Details


Totals Coverage Status
Change from base Build 9988332527: 0.0%
Covered Lines: 51675
Relevant Lines: 53798

💛 - Coveralls
mraspaud commented 2 months ago

Ah, I see it is ready, merging