Closed djhoese closed 4 months ago
Merging this could wait a bit for the discussion in the xarray PR to settle to know if this is needed at all. Either way, the datetime change in this PR should be included.
Attention: Patch coverage is 66.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 95.95%. Comparing base (
4011541
) to head (b62f10b
). Report is 454 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
satpy/writers/awips_tiled.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
satpy/writers/awips_tiled.py | 2 | 3 | 66.67% | ||
<!-- | Total: | 2 | 3 | 66.67% | --> |
Totals | |
---|---|
Change from base Build 9973181832: | 0.0% |
Covered Lines: | 51677 |
Relevant Lines: | 53800 |
Oh I should have made this a draft instead of just posting my previouscomment. I have an xarray PR that should make this unnecessary.
Ah, sorry, missed the comment...
Fixes compatibility with (currently unstable) xarray for the AWIPS tiled (
awips_tiled
) writer when using the default_Unsigned
fill value of-1
. Starting withhttps://github.com/pydata/xarray/pull/9136
Xarray automatically converts the _FillValue to the proper dtype in a way that does not allow (or rather numpy does not allow) certain values to be automatically cast between types. In the case of this -1 it was trying to cast it directly to the unsigned type (give or take some bit depth differences) and failing. The -1 was just a convenience in the writer code anyway. I've added the necessary code to specify the fill value as the unsigned numpy type so that xarray can convert it when the file is saved.
AUTHORS.md
if not there already