Initial implementation of EUMETSAT IASI-NG reader

roche-emmanuel commented 3 months ago

This PR introduces the initial implementation of the IASI-NG reader for Satpy.

The changes provided here are self-contained in three files:

satpy/readers/iasi_ng_l2_nc.py: The implementation file for the reader.
satpy/etc/readers/iasi_ng_l2_nc.yaml: The YAML configuration file for the reader.
satpy/tests/reader_tests/test_iasi_ng_l2_nc.py: The unit tests for the reader.

There are still a few points I need to address (this list may be extended progressively):

[x] Check support for products with two-letter names (O3 and CO), as I don't think they will pass the current file pattern.
[x] Confirm with the EUMETSAT team whether the processing logic needs to be adjusted (awaiting clarification on some points concerning the product file specs).
[x] Extend the unit tests to perform more comprehensive checks on different products (currently only testing with TWV).
[x] Clean the code and remove debug outputs (e.g., print(...) statements).
[x] Clarify what needs to be done/added concerning the documentation of this reader.
[x] Add my name to the AUTHORS.md file.

The idea here is to start this PR early in the development phase to get early feedback and review notes from you, ensuring we are on the right track for eventual PR acceptance.

If you have any feedback on this PR already, please let me know 😊! In the meantime, I will continue working on the points mentioned above and will provide additional details on the changes as they are made on the feature branch.

Thanks for your help 🙏!

roche-emmanuel commented 3 months ago

Alright, so I see from the workflows above that there are some failures due to the formatting of the file, I should maybe start with this before moving forward with the remaining code changes 😉.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.36735% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (a4b8c8d) to head (1a7b8f6). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
satpy/readers/iasi_ng_l2_nc.py	96.35%	7 Missing :warning:
satpy/tests/reader_tests/test_iasi_ng_l2_nc.py	99.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2879 +/- ## ========================================== + Coverage 96.09% 96.11% +0.02% ========================================== Files 377 379 +2 Lines 55074 55564 +490 ========================================== + Hits 52924 53406 +482 - Misses 2150 2158 +8 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2879/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2879/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `3.91% <0.00%> (-0.04%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2879/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.21% <98.36%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 11507327103

Details

484 of 492 (98.37%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 96.221%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
satpy/tests/reader_tests/test_iasi_ng_l2_nc.py	298	299	99.67%
satpy/readers/iasi_ng_l2_nc.py	186	193	96.37%
<!--	Total:	484	492	98.37%	-->

Totals
Change from base Build 11485792071:	0.02%
Covered Lines:	53652
Relevant Lines:	55759

💛 - Coveralls

roche-emmanuel commented 1 month ago

Hi everyone,

We now think that this MR is ready for a review by the Satpy team, so please let me know if you have any feedback on it. Thanks 😉!

pytroll / satpy