pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.08k stars 298 forks source link

Bugfix the VIIRS lowres version of the day-microphysics. #2957

Closed adybbroe closed 1 month ago

adybbroe commented 1 month ago

This PR fixes a bug with the VIIRS low-resolution day-microphysics RGB using M-band.

It should use only M-bands! Currently it use the default nir-refelctance dataset, and that will then use the I-bands to try derive this. It should be forced to using the M bands.

adybbroe commented 1 month ago

This is what I saw:

[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delaying generation of DataID(name='M12', wavelength=WavelengthRange(min=3.61, central=3.7, max=3.79, unit='µm'), resolution=742, calibration=<2>, modifiers=('nir_reflectance',)) because of incompatible areas
[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delaying generation of DataID(name='day_microphysics') because of dependency's delayed generation: DataID(name='M15', wavelength=WavelengthRange(min=10.263, central=10.763, max=11.263, unit='µm'), resolution=742, calibration=<2>, modifiers=())
[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delayed prerequisite for 'DataID(name='day_microphysics')': 'DataID(name='M15', wavelength=WavelengthRange(min=10.263, central=10.763, max=11.263, unit='µm'), resolution=742, calibration=<2>, modifiers=())'
[WARNING: 2024-10-25 15:10:15 : satpy.scene] The following datasets were not created and may require resampling to be generated: DataID(name='day_microphysics')
[DEBUG: 2024-10-25 15:10:15 : asyncio] Using selector: EpollSelector

Was puzzled why it delayed the creation of this, as I expected it to only use M-bands. There is a day_microphysics_hires if you specifically want the high res version using I-bands. So I expected this one to use M-bands only!

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.09%. Comparing base (118fc93) to head (d6b8d01). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2957 +/- ## ======================================= Coverage 96.09% 96.09% ======================================= Files 377 377 Lines 55110 55125 +15 ======================================= + Hits 52960 52975 +15 Misses 2150 2150 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2957/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `3.94% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.19% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11519400125

Details


Totals Coverage Status
Change from base Build 11519299470: 0.0%
Covered Lines: 53219
Relevant Lines: 55318

💛 - Coveralls