gerritholl
commented
5 years ago I have a hard time bisecting this:
- Success in 56f5b006, 2be73260, 06248d5e, 1616d2cd, 5fa54e72, d888da6c
- Failure with
AttributeErrorin 7b18f701 and all recent versions. - Failure with metaclass conflict in 9bcea29c, 69cde3e6, d12597df, ca3ea366, 764062b2, 30807fba, e0c093a9, 0251bc60, 1c43d6ea, e34cb2d5, 11928f37, 02b4f662, 1bc99828, dffc2b76, 47d7f349, 6594749c and others, ancient versions
It looks like there's too much non-linear history going on, I don't succeed in figuring out. This is my rather inefficient and also inconclusive git bisect log:
# good: [06248d5e4fee1efad3ac8e6cff6d46657639a6d0] update changelog
git bisect good 06248d5e4fee1efad3ac8e6cff6d46657639a6d0
# bad: [b574b1f755a5e63a6b6760ce6e425e8e105b0aae] Bump version: 0.8.1 → 0.9.0-alpha.0
git bisect bad b574b1f755a5e63a6b6760ce6e425e8e105b0aae
# bad: [774f7939a1b64b4382581e98d1c996d598acc4f9] Bugfix: remove unneeded +1
git bisect bad 774f7939a1b64b4382581e98d1c996d598acc4f9
# bad: [5da5a755774d6a7401ce980d6f4f44550d0de9a1] Remove unused dependencies
git bisect bad 5da5a755774d6a7401ce980d6f4f44550d0de9a1
# bad: [f67c47152ca0437fc6015a45b69531d379a04708] Do not resample datasets without an area
git bisect bad f67c47152ca0437fc6015a45b69531d379a04708
# bad: [f8f7502f89a989c74348161b557a7e88fdd3e691] Merge develop
git bisect bad f8f7502f89a989c74348161b557a7e88fdd3e691
# bad: [fe37a9ae9b638ac2c1fd4ed5b85d7135a0aff95a] Merge branch 'feature-xarray' of github.com:pytroll/satpy into feature-xarray
git bisect bad fe37a9ae9b638ac2c1fd4ed5b85d7135a0aff95a
# bad: [c603c1c63b569ef0eee8140a7c557bbc2ff7c692] Fix dask array depedency
git bisect bad c603c1c63b569ef0eee8140a7c557bbc2ff7c692
# good: [5fa54e7221bae206d147b3c8848320a7a64f4d48] Merge pull request #84 from eysteinn/composite-snowage-fix
git bisect good 5fa54e7221bae206d147b3c8848320a7a64f4d48
# bad: [7b18f701f45ed4f2cdcaefe63408fd0e437e60a3] Merge branch 'develop' into feature-xarray
git bisect bad 7b18f701f45ed4f2cdcaefe63408fd0e437e60a3
# good: [5fa54e7221bae206d147b3c8848320a7a64f4d48] Merge pull request #84 from eysteinn/composite-snowage-fix
git bisect good 5fa54e7221bae206d147b3c8848320a7a64f4d48
# bad: [1055effb83e0d185d310eba40a8a02dae574fd2e] Merge branch 'develop' into feature-xarray
git bisect bad 1055effb83e0d185d310eba40a8a02dae574fd2e
# good: [1616d2cdbbb7e87ec403673e6f48e31403728f70] Update documentation to add hrit_goes
git bisect good 1616d2cdbbb7e87ec403673e6f48e31403728f70
# bad: [08adb2d22f5bf051e37c5b341b7e25a22929015b] Create x and y dimensions for swathdefs also
git bisect bad 08adb2d22f5bf051e37c5b341b7e25a22929015b
# bad: [7b18f701f45ed4f2cdcaefe63408fd0e437e60a3] Merge branch 'develop' into feature-xarray
git bisect bad 7b18f701f45ed4f2cdcaefe63408fd0e437e60a3
# skip: [1c43d6eac566ed01a5a03ecf47fbe596168da5ab] Add xarray support for hrit_msg reader
git bisect skip 1c43d6eac566ed01a5a03ecf47fbe596168da5ab
# skip: [ca3ea366160ff576e80fafc17daf5099e53e9ff8] Make aapp_l1b reader work with xarray
git bisect skip ca3ea366160ff576e80fafc17daf5099e53e9ff8
# skip: [0251bc60e4b16685c9241cde466151d4c4b6db02] Add xarray support for fci_fdhsi reader
git bisect skip 0251bc60e4b16685c9241cde466151d4c4b6db02
# skip: [dffc2b76f240b11c65141266c55a5d9b477b058c] Convert hdfeos_l1b to xarray
git bisect skip dffc2b76f240b11c65141266c55a5d9b477b058c
# skip: [e34cb2d58fbd6d185015a60ad1f5a4a5516b9ef6] Add support for ABI with xarrays
git bisect skip e34cb2d58fbd6d185015a60ad1f5a4a5516b9ef6
# skip: [764062b2ee3c953e01ed796aff1bd8ec0168e363] Add x and y coordinates for datasets that miss them
git bisect skip 764062b2ee3c953e01ed796aff1bd8ec0168e363
# skip: [11928f37f69886f1d71e728ad72cf163c2c2b94b] Merge branch 'develop' into feature-xarray
git bisect skip 11928f37f69886f1d71e728ad72cf163c2c2b94b
# skip: [1bc998288c733926ba3983e7f96c899d9cd7c88d] Fix composites for xarrays
git bisect skip 1bc998288c733926ba3983e7f96c899d9cd7c88d
# skip: [47d7f3497724674a46e94f5062d401ac986d93e1] WIP xarray adaptation
git bisect skip 47d7f3497724674a46e94f5062d401ac986d93e1
# good: [2be73260bb27b6baa97d648f15ba7c16a5987639] Merge pull request #177 from pytroll/bugfix-viirs
git bisect good 2be73260bb27b6baa97d648f15ba7c16a5987639
# skip: [30807fba9c98a3a09571f9feeea4e77ede0bae2c] Do not compute sunz corrections in place
git bisect skip 30807fba9c98a3a09571f9feeea4e77ede0bae2c
# skip: [e0c093a9de5668c237e3cd552a280147668f88d0] Patch CF writer for geos and adding latlons
git bisect skip e0c093a9de5668c237e3cd552a280147668f88d0
# skip: [69cde3e68fec347100dd3319a1bd5201a88e6e2f] Add first attempt to cf's save_dataset
git bisect skip 69cde3e68fec347100dd3319a1bd5201a88e6e2f
# skip: [9bcea29c2b0e41ae1ac20bd2c6d0db8a5d5fc9e8] Fix yaml_reader tests
git bisect skip 9bcea29c2b0e41ae1ac20bd2c6d0db8a5d5fc9e8
# good: [56f5b0067d7475bae52ee85aeb79bc68c9ef5c33] Add GenericCompositor
git bisect good 56f5b0067d7475bae52ee85aeb79bc68c9ef5c33
# skip: [02b4f66202547315ff25401a76ce442ea6e4b75b] More xarray adaptations
git bisect skip 02b4f66202547315ff25401a76ce442ea6e4b75b
# skip: [d12597dff0b8e97542b8dbfbbbb184ff8100af4c] Adapt realistic_colors composite to xarray
git bisect skip d12597dff0b8e97542b8dbfbbbb184ff8100af4c
# skip: [9bcea29c2b0e41ae1ac20bd2c6d0db8a5d5fc9e8] Fix yaml_reader tests
git bisect skip 9bcea29c2b0e41ae1ac20bd2c6d0db8a5d5fc9e8
# skip: [6594749ccd45cd1e94f81648cf44454034d7f035] Try out xarray on abi l1b
git bisect skip 6594749ccd45cd1e94f81648cf44454034d7f035
# skip: [43d207cb16dfd3d444be87fd507fca3bb14d590d] Replace BWCompositor and RGBCompositor with GenericCompositor in YAML
git bisect skip 43d207cb16dfd3d444be87fd507fca3bb14d590d
# skip: [8be84c2d318ee2105ca428bce5b9ac51d0976260] Add depracition warnings to BWCompositor and RGBCompositor
git bisect skip 8be84c2d318ee2105ca428bce5b9ac51d0976260
# good: [d888da6cd36c9220faae9d9e8e1d251280416b48] Add two missing deprecation warning lines
git bisect good d888da6cd36c9220faae9d9e8e1d251280416b48
ameraner
Describe the bug
The MTG-LI reader fails with recent versions of
satpy.To Reproduce
Actual results
Using
satpyversions 0.9.0—0.9.4 or newer up to latest master, it givesAttributeError: 'NoneType' object has no attribute 'data':Using versions 0.7.3–0.7.8 or 0.8.0–0.8.4, it is successful (although prints a warning starting with 0.8.0):
Using versions 0.7.2 or older:
I have tried to use
git bisect, but there are too many merges going and different combinations of problems on different sides for me to find the commit that caused this problem, I also hit intermediate commits failing for different reasons yet (and then I'm unsure about good or bad, and skip just hits me another commit with the same problem).Environment Info:
Linux, openSUSE 15.0. Python 2.7 (it fails differently on Python 3.7, but that is a separate issue). Various versions of satpy as indicated.
from satpy.config import check_satpy; check_satpy()]