search

pytroll / trollbufr

PyTroll BUFR reader
http://trollbufr.readthedocs.io/
GNU Lesser General Public License v3.0
11 stars 7 forks source link

Updating to python 3 #17

Closed bbakernoaa closed 6 years ago

alexmaul commented 6 years ago

Thank you for the PR! Just this week I was working on Python3-support ... I think your changes are more thorough than mine. I'll review/test your PR the next days.

There are a lot of changes in format/style, did you use a formatting tool (/which one)?

/alex

bbakernoaa commented 6 years ago

@alexmaul I just used futurize. So please test it and make sure it still works.

bbakernoaa commented 6 years ago

@alexmaul I use Atom created by github with the google formatting extension yapf and an autopep8 checker

alexmaul commented 6 years ago

Hi @bbakernoaa , it seems my code isn't really suitable to "just futurize". Your PR doesn't work well (in either Python2 nor Python3) -- there's some logic which needs work (like //-operator).

I made a PR from my fork to a new branch "python3-support", could you change your PR to target that? (If that's possible, so I can merge your PR with mine.)

alexmaul commented 6 years ago

There were several issues with code logic, which weren't solved by this PR. Several changes from this PR were cherry-picked and combined with others into a seperate PR, which was merged. Thanks to bbakernoaa for valid and helpfull input.