pytroll / trollflow2

Next generation Trollflow. Trollflow is for batch-processing satellite data using Satpy
https://trollflow2.readthedocs.org/
GNU General Public License v3.0
10 stars 15 forks source link

Add an option to configure a timeout for plugins #104

Closed gerritholl closed 3 years ago

gerritholl commented 3 years ago

Allow users to configure a timeout for each plugin/worker that is run. If defined, this indicates the number in seconds trollflow2 will wait for the job to complete.

codecov[bot] commented 3 years ago

Codecov Report

Merging #104 (c7c655b) into master (34b704c) will increase coverage by 0.02%. The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   93.20%   93.23%   +0.02%     
==========================================
  Files           9        9              
  Lines        1737     1759      +22     
==========================================
+ Hits         1619     1640      +21     
- Misses        118      119       +1     
Flag Coverage Δ
unittests 93.23% <95.45%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollflow2/launcher.py 76.59% <87.50%> (+0.38%) :arrow_up:
trollflow2/tests/test_launcher.py 98.55% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34b704c...c7c655b. Read the comment docs.

gerritholl commented 3 years ago

The test failure for (3.9, ubuntu-latest, true) (whatever true means here) does not appear related to this PR.

ghost commented 3 years ago

Congratulations :tada:. DeepCode analyzed your code in 0.741 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

gerritholl commented 3 years ago

Retry DeepCode

gerritholl commented 3 years ago

The CodeFactor failure is in a part of the code I did not touch. I don't know why the (3.9, ubuntu-latest, true) test fails, but it doesn't appear to be in code I touched either.

gerritholl commented 3 years ago

The unstable test is failing if satpy is but pyresample isn't installed. Is that really a situation we need to cover?

gerritholl commented 3 years ago

This test will pass if https://github.com/pytroll/trollflow2/pull/110 is merged first.

mraspaud commented 3 years ago

For some reason the tests of macos with python 3.7 are failing now...

adybbroe commented 3 years ago

LGTM. Thanks @gerritholl I would not bother about the CodeFactor issue for this PR!