pytroll / trollflow2

Next generation Trollflow. Trollflow is for batch-processing satellite data using Satpy
https://trollflow2.readthedocs.org/
GNU General Public License v3.0
10 stars 15 forks source link

Remove the ppp_config_dir scene creation parameter for satpy>=0.26.0 compatibility #106

Closed mraspaud closed 3 years ago

mraspaud commented 3 years ago

As of satpy 0.26.0, the scene creation doesn't accept the ppp_config_dir parameter anymore. This PR removes it, since the prefered usage is to path SATPY_CONFIG_DIR as an environment variable now.

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 (54c3759) into master (0f87b0b) will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   93.58%   93.48%   -0.10%     
==========================================
  Files           8        9       +1     
  Lines        1668     1674       +6     
==========================================
+ Hits         1561     1565       +4     
- Misses        107      109       +2     
Flag Coverage Δ
unittests 93.48% <100.00%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollflow2/plugins/__init__.py 91.04% <ø> (ø)
trollflow2/tests/test_trollflow2.py 99.85% <100.00%> (ø)
trollflow2/__init__.py 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f87b0b...54c3759. Read the comment docs.

mraspaud commented 3 years ago

duplicate of #97

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

djhoese commented 3 years ago

FYI It is SATPY_CONFIG_PATH not DIR.