Closed pnuu closed 2 years ago
Something has changed in either dpath.util.values()
or .delete()
. Downgrading to 'dpath<1.5'
the tests pass locally.
Merging #134 (cae3810) into main (ac335a6) will increase coverage by
0.24%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 94.84% 95.08% +0.24%
==========================================
Files 11 11
Lines 2268 2280 +12
==========================================
+ Hits 2151 2168 +17
+ Misses 117 112 -5
Flag | Coverage Δ | |
---|---|---|
unittests | 95.08% <100.00%> (+0.24%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
trollflow2/dict_tools.py | 94.23% <100.00%> (ø) |
|
trollflow2/launcher.py | 87.37% <100.00%> (+1.26%) |
:arrow_up: |
trollflow2/plugins/__init__.py | 91.95% <100.00%> (ø) |
|
trollflow2/tests/test_dict_tools.py | 91.66% <100.00%> (+3.73%) |
:arrow_up: |
trollflow2/tests/test_trollflow2.py | 99.43% <100.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ac335a6...cae3810. Read the comment docs.
We've had a version limitation
dpath<1.5
as it seemed the.util
sub-package didn't exist after that. That was not the case, and everything works if we doimport dpath.util
. This fixes the imports, and removes the version restriction.Internally "use satellite projection", which in the product list is marked by using
null
as area name, now uses'None'
as the newer versions ofdpath
only support string and integer names.flake8 trollflow2