search

pyupio / changelogs

A changelog finder and parser for packages available on pypi, npm and rubygems.
https://pyup.io
MIT License
63 stars 26 forks source link

pyup not finding changelog #3

Closed cuducos closed 7 years ago

cuducos commented 7 years ago

Description

I'm maintain a couple of PyPI packages (webassets-elm, for example) but everytime pyup opens a PR (in repositories that use my package) it says it can't find any changelog.

What I Did

I installed changelogs and tested it, but always had an empty stdout. My changelog is the CHANGELOG file in the root of the repo, but I tried renaming and moving it all around (no success):

$ ls -laGh | grep CHANGELOG
-rw-r--r--@  1 cuducos  staff   362B Jan 27 13:17 CHANGELOG
$ changelogs webassets_elm
$ git mv CHANGELOG changelog.md
$ changelogs webassets_elm
$ gt mv changelog.md changelog
$ changelogs webassets_elm
$ git mv changelog.md webassets_elm/CHANGELOG
$ changelogs webassets_elm
$

Am I missing anything or is this a bug?

jayfk commented 7 years ago

The parser is unable to parse the changelog as it discards all lines beginning with * (while looking for a release head).

It's horrible, but overall it works better this way. If you want to see the reasoning behind this, take a look at the horrible world of changelog parsing here: https://github.com/pyupio/changelogs/blob/master/changelogs/parser.py#L36

cuducos commented 7 years ago

Good to know! It works now. Many thanks, @jayfk ; )

jayfk commented 7 years ago

Great. I'll have to trigger this manually for pyup.io to fetch the new changelog.

cuducos commented 7 years ago

the horrible world of changelog parsing here

Horrible but well commented in the source code — thanks for that too ; )

Great. I'll have to trigger this manually for pyup.io to fetch the new changelog.

We can wait for the next update, no worries ; )