search

pyupio / dparse

A parser for Python dependency files
MIT License
61 stars 23 forks source link

add support for Dockerfiles #12

Closed jayfk closed 4 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #12 into master will decrease coverage by 0.19%. The diff coverage is 98.97%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
- Coverage   99.84%   99.64%   -0.2%     
=========================================
  Files          11       11             
  Lines         662      857    +195     
=========================================
+ Hits          661      854    +193     
- Misses          1        3      +2
Impacted Files Coverage Δ
dparse/filetypes.py 100% <100%> (ø) :arrow_up:
dparse/parser.py 99.48% <100%> (+0.18%) :arrow_up:
tests/test_parse.py 100% <100%> (ø) :arrow_up:
dparse/dependencies.py 97.26% <50%> (-2.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec425c9...48bcbae. Read the comment docs.

rafaelpivato commented 4 years ago

Besides being this way too much stale, I don't think it aligns with our efforts here. Dparse is supposed to parse Python dependencies and, even though it might sound great being able to parse Dockerfiles and magically discover later which Python packages are being mentioned there, it doesn't looks like there is a de facto standard to do that.

With that in mind, and given the fact that this PR does not actually yet detect Python versions inside a Dockerfile (which is not a place to declare Python packages), I am closing this.