search

pyupio / dparse

A parser for Python dependency files
MIT License
61 stars 23 forks source link

Fix "AttributeError: SafeConfigParser instance has no attribute 'values'" #33

Closed thanatos closed 1 year ago

thanatos commented 5 years ago

This method simply doesn't exist, and this appears to be a typo. The correct method appears to be .sections(); there is similar (correct) code in ToxINIParser on L293.

However, the rest of this class seems to not correctly use the configparser/ConfigParser API correctly at all; I've fixed it to do so.

This should fix — (break to get the GitHub auto-close feature to back off) — https://github.com/pyupio/pyup/issues/294 once pyup updates to a new version containing this fix, I hope.

The relevant section of the documentation for configparser.

rafaelpivato commented 4 years ago

Thanks for this, @thanatos!

Would you mind rebasing this, please? We pushed some fixes to master (which dropped Python 2.7, 3.3 and 3.4 support, BTW) and that should maybe impact your code positively.