pyupio / dparse

A parser for Python dependency files
MIT License
61 stars 23 forks source link

pipenv is installed even without optional flag #44

Closed sobolevn closed 4 years ago

sobolevn commented 4 years ago

Description

dparse installs pipenv even when [pipenv] optional target is not specified.

Related #25

What I Did

  1. pip install dparse, log:
» pip install dparse
Collecting dparse
  Using cached https://files.pythonhosted.org/packages/c7/c2/dcd7da3b65c45f82a518d413cc253c8fa7aaf8c3c5e6ed1c7900900f546f/dparse-0.5.0-py3-none-any.whl
Collecting packaging (from dparse)
  Using cached https://files.pythonhosted.org/packages/62/0a/34641d2bf5c917c96db0ded85ae4da25b6cd922d6b794648d4e7e07c88e5/packaging-20.3-py2.py3-none-any.whl
Collecting pyyaml (from dparse)
  Downloading https://files.pythonhosted.org/packages/64/c2/b80047c7ac2478f9501676c988a5411ed5572f35d1beff9cae07d321512c/PyYAML-5.3.1.tar.gz (269kB)
     |████████████████████████████████| 276kB 3.6MB/s 
Collecting toml (from dparse)
  Using cached https://files.pythonhosted.org/packages/a2/12/ced7105d2de62fa7c8fb5fce92cc4ce66b57c95fb875e9318dba7f8c5db0/toml-0.10.0-py2.py3-none-any.whl
Collecting pipenv (from dparse)
  Using cached https://files.pythonhosted.org/packages/13/b4/3ffa55f77161cff9a5220f162670f7c5eb00df52e00939e203f601b0f579/pipenv-2018.11.26-py3-none-any.whl
Collecting pyparsing>=2.0.2 (from packaging->dparse)
  Using cached https://files.pythonhosted.org/packages/5d/bc/1e58593167fade7b544bfe9502a26dc860940a79ab306e651e7f13be68c2/pyparsing-2.4.6-py2.py3-none-any.whl
Collecting six (from packaging->dparse)
  Using cached https://files.pythonhosted.org/packages/65/eb/1f97cb97bfc2390a276969c6fae16075da282f5058082d4cb10c6c5c1dba/six-1.14.0-py2.py3-none-any.whl
Requirement already satisfied: pip>=9.0.1 in ./.venv/lib/python3.7/site-packages (from pipenv->dparse) (19.2.3)
Requirement already satisfied: setuptools>=36.2.1 in ./.venv/lib/python3.7/site-packages (from pipenv->dparse) (41.2.0)
Collecting virtualenv-clone>=0.2.5 (from pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/ba/f8/50c2b7dbc99e05fce5e5b9d9a31f37c988c99acd4e8dedd720b7b8d4011d/virtualenv_clone-0.5.3-py2.py3-none-any.whl
Collecting virtualenv (from pipenv->dparse)
  Downloading https://files.pythonhosted.org/packages/50/85/35c61f2ec4ab1296cfcfa0f38f1814b030778c25af191656af9a83f69ca4/virtualenv-20.0.12-py2.py3-none-any.whl (4.6MB)
     |████████████████████████████████| 4.6MB 10.8MB/s 
Collecting certifi (from pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/b9/63/df50cac98ea0d5b006c55a399c3bf1db9da7b5a24de7890bc9cfd5dd9e99/certifi-2019.11.28-py2.py3-none-any.whl
Collecting filelock<4,>=3.0.0 (from virtualenv->pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/93/83/71a2ee6158bb9f39a90c0dea1637f81d5eef866e188e1971a1b1ab01a35a/filelock-3.0.12-py3-none-any.whl
Collecting importlib-metadata<2,>=0.12; python_version < "3.8" (from virtualenv->pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/8b/03/a00d504808808912751e64ccf414be53c29cad620e3de2421135fcae3025/importlib_metadata-1.5.0-py2.py3-none-any.whl
Collecting appdirs<2,>=1.4.3 (from virtualenv->pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/56/eb/810e700ed1349edde4cbdc1b2a21e28cdf115f9faf263f6bbf8447c1abf3/appdirs-1.4.3-py2.py3-none-any.whl
Collecting distlib<1,>=0.3.0 (from virtualenv->pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/7d/29/694a3a4d7c0e1aef76092e9167fbe372e0f7da055f5dcf4e1313ec21d96a/distlib-0.3.0.zip
Collecting zipp>=0.5 (from importlib-metadata<2,>=0.12; python_version < "3.8"->virtualenv->pipenv->dparse)
  Using cached https://files.pythonhosted.org/packages/b2/34/bfcb43cc0ba81f527bc4f40ef41ba2ff4080e047acb0586b56b3d017ace4/zipp-3.1.0-py3-none-any.whl
Installing collected packages: pyparsing, six, packaging, pyyaml, toml, virtualenv-clone, filelock, zipp, importlib-metadata, appdirs, distlib, virtualenv, certifi, pipenv, dparse
  Running setup.py install for pyyaml ... done
  Running setup.py install for distlib ... done
Successfully installed appdirs-1.4.3 certifi-2019.11.28 distlib-0.3.0 dparse-0.5.0 filelock-3.0.12 importlib-metadata-1.5.0 packaging-20.3 pipenv-2018.11.26 pyparsing-2.4.6 pyyaml-5.3.1 six-1.14.0 toml-0.10.0 virtualenv-20.0.12 virtualenv-clone-0.5.3 zipp-3.1.0
WARNING: You are using pip version 19.2.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
benzkji commented 4 years ago

same behaviour here. got dparse via safety, and then pipenv...?

adamchainz commented 4 years ago

Yes it seems #43 moved it to a non-optional dependency.