search

pyupio / dparse

A parser for Python dependency files
MIT License
61 stars 23 forks source link

Please release a new version which drops toml as dependency #65

Closed oz123 closed 1 year ago

oz123 commented 1 year ago

This commit 31a1d5b0442b124c2c45a0dfae6632788e3c9cea is really significant for pipenv which vendors dparse. I'd be happy to see this included in an official version.

oz123 commented 1 year ago

ping

yeisonvargasf commented 1 year ago

Hi @oz123, I hope everything is going great; I'm sorry for not getting back to you sooner.

We'll include this in a coming release in the following weeks. Let me know if you need this included as soon as possible; if so, we are open to considering releasing it before.

oz123 commented 1 year ago

Thanks for the reply. The sooner the better :-) Ok. Seriously, the reason I asked for the release is that without this we need to manually patch dparse I'm pipenv. Which is error prone and make the release process cumbersome.

yeisonvargasf commented 1 year ago

@oz123, thanks for explaining, that makes sense; I'll launch a release in the following (~3) days.

yeisonvargasf commented 1 year ago

Hi @oz123, I just pushed the 0.6.3 release.

Much work is going on for the following Safety versions, including new plans (improvements) for dparse, so we'll be releasing dparse versions frequently.

oz123 commented 1 year ago

Thank you very much. If you don't mind, for the next versions, please use lazy imports when adding new dependencies. As you already do for the conda parser:

class CondaYMLParser(Parser):
    """

    """

    def parse(self):
        """

        :return:
        """
        import yaml
        try:
        ...

This way we can include dparse without the optional dependency of yaml which is not required for pipenv.