search

pyupio / pyup

A tool to update your project's dependencies on GitHub. Runs on pyup.io, comes with a command line interface.
https://pyup.io
MIT License
454 stars 67 forks source link

Fixing requirements object not iterable on bad schema. #393

Open nicholasks opened 4 years ago

nicholasks commented 4 years ago

This will avoid raise "'NoneType' object is not iterable" error when user has a bad schema regarding requirements.txt on .pyup.yml file.

Example schema that was triggering the error:

# Specify requirement files by hand, default is empty
# default: empty
# allowed: list
requirements:
#  - requirements/staging.txt:

Should we warn users about the bad schema? And how about the documentation (.pyup.yml example file), maybe the "default empty" is leading users to do that, and I think is in certain way controversial, since below says "allowed: list".

codecov[bot] commented 4 years ago

Codecov Report

Merging #393 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   94.20%   94.21%           
=======================================
  Files          11       11           
  Lines        1157     1159    +2     
=======================================
+ Hits         1090     1092    +2     
  Misses         67       67
Impacted Files Coverage Δ
pyup/config.py 98.91% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fb8638...deab8bd. Read the comment docs.