search

pyupio / safety

Safety checks Python dependencies for known security vulnerabilities and suggests the proper remediations for vulnerabilities detected.
https://safetycli.com/product/safety-cli
MIT License
1.66k stars 141 forks source link

Incorrect used DB #317

Closed nicholasks closed 3 years ago

nicholasks commented 3 years ago

The used DB displayed is not the right when using a local DB --db among with --key.

Since --db overrides any external DB, safety should display "Using local DB" instead of "using pyup.io's DB". Users shouldn't use both parameters together but since we are displaying what was used, at least we should display the right one.

codecov[bot] commented 3 years ago

Codecov Report

Merging #317 (45a5ec9) into master (63e6b21) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   69.51%   69.51%           
=======================================
  Files           8        8           
  Lines         538      538           
=======================================
  Hits          374      374           
  Misses        164      164
Impacted Files Coverage Δ
safety/formatter.py 50.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63e6b21...45a5ec9. Read the comment docs.

nicholasks commented 3 years ago

LGTM. Can you please rebase from master and add information to HISTORY?

@rafaelpivato done!