pyupio / safety

Safety checks Python dependencies for known security vulnerabilities and suggests the proper remediations for vulnerabilities detected.

https://safetycli.com/product/safety-cli

MIT License

1.66k stars 141 forks source link

Simplify Dockerfilei386 by using i386/python base image #328

Closed PeterDaveHello closed 3 years ago

PeterDaveHello commented 3 years ago

Use i386/python:3.6-slim instead of i386/ubuntu:18.04, save the time and network bandwidth to install python, also align to Dockerfile(python:3.6-slim), make the environment more consistent, also save the disk space and image size:

REPOSITORY                    TAG                 IMAGE ID            CREATED             SIZE
new                           latest              a163d1c2dd4d        About an hour ago   161MB
old                           latest              1a5e52fb3e2e        11 minutes ago      485MB

rafaelpivato commented 3 years ago

We use the docker image to build some binaries via AppVeyor. If you could please check the errors for the failing check, that would be helpful.

Your point on reducing file size is awesome.

PeterDaveHello commented 3 years ago

I didn't notice that AppVeyor will be affected, will take a look and see how to deal with it.

PeterDaveHello commented 3 years ago

Looks like the binutils package is missing, I'll see not using slim image or install it manually, which one is better here. https://pyinstaller.readthedocs.io/en/stable/requirements.html#gnu-linux

codecov[bot] commented 3 years ago

Codecov Report

Merging #328 (ef50ad8) into master (4a8d983) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files           8        8           
  Lines         514      514           
=======================================
  Hits          368      368           
  Misses        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a8d983...ef50ad8. Read the comment docs.

PeterDaveHello commented 3 years ago

@rafaelpivato should be fixed now!