pyure / infitech-prototype

The Infitech 3 Repo, codenamed Prototype
13 stars 13 forks source link

Crash with unusual torch placement #523

Closed TLaviron closed 5 years ago

TLaviron commented 5 years ago

Hello, I have experienced a server crash, that seems to have occurred when a torch was placed when it shouldn't have.

I was trying to access a machine inventory. I was holding torches in my hand. After right clicking, since the UI took some time opening, A torch was placed on the front of the machine I was pointing at. I've seen this happen a few times, I think.

However in this case, there was already a block in front of the machine in question, specifically a polyethylene pipe draining the machine (which had a pump+filter on its side). So, the torch tried to replace a pipe (or actually replaced it), and the server crashed right after that. I am not entirely certain this is what actually happened, but its what I could see before getting disconnected.

Save is corrupted, had to restore a backup. I have attached a crash log. crash-2019-05-12_18.42.12-server.txt I can also provide a log from the debug output, it may provide additional useful information. server_debug.log

TLaviron commented 5 years ago

Update: this is reproducible on a simple setup 2019-05-15_19 24 45

For the exact setup, that's an electrolyzer MV, with a pump + fluid filter filtering oxygen, pumping into a 2-bloc polyethylene tiny pipe, and emptying into a quantum tank LV. Shift-right clicking to force a torch placement on the side with the covers causes a crash.

I would guess that the actual machine types or pipe types don't matter, but I have not yet tested again with different setups (It requires relaunching the client each time if testing in singleplayer).

pyure commented 5 years ago

Hey TLaviron, I believe this is a known issue. https://github.com/TheCBProject/ForgeMultipart/issues/56

I check up on it from time to time to see if there's any progress.

pyure commented 5 years ago

Its been a long time coming, but I think this is fixed by the mod dev. I need to do a bit more testing, but should roll out with next version.

pyure commented 5 years ago

Fixed in 1.09