pyushkevich / greedy

Very fast greedy diffeomorphic registration code
GNU General Public License v3.0
59 stars 16 forks source link

will this work on ITK 5.1.2? #19

Closed mschachter closed 3 years ago

mschachter commented 3 years ago

Hi there! I'm trying to upgrade the dependencies of CaPTk, which utilizes greedy. As noted in another greedy issue, I'm running into deprecated/missing itkBarrier.h. Somewhat ominously, it was noted that "there seem to be quite some other issues with compatiblity to ITKv5".

Can I expect greedy to work with ITK 5.1.2 if I address the itkBarrier issue, or are there some fundamental issues that go beyond simple renaming?

pyushkevich commented 3 years ago

I have not tried ITK 5 at all yet. I think it should work because the changes to the core classes are supposed to be rather cosmetic and Greedy only relies on core classes. If you work on porting I would appreciate if you could submit a pull request, as this is on my list of things to do...

On Sun, Dec 6, 2020 at 11:05 AM mschachter notifications@github.com wrote:

Hi there! I'm trying to upgrade the dependencies of CaPTk https://github.com/CBICA/CaPTk, which utilizes greedy. As noted in another greedy issue https://github.com/pyushkevich/greedy/issues/9, I'm running into deprecated/missing itkBarrier.h. Somewhat ominously, it was noted that "there seem to be quite some other issues with compatiblity to ITKv5".

Can I expect greedy to work with ITK 5.1.2 if I address the itkBarrier issue, or are there some fundamental issues that go beyond simple renaming?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pyushkevich/greedy/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJPEW3ZDFRQV6MWPHBXTY3STOTWFANCNFSM4UPNFH6A .

-- Paul A. Yushkevich, Ph.D. Professor of Radiology Penn Image Computing and Science Laboratory University of Pennsylvania Perelman School of Medicine

mschachter commented 3 years ago

Ok, no problem, thanks for letting me know! I'm already working on it, will submit a PR if things work out.