Open vanossj opened 3 years ago
Jeff,
I think this is already fixed in the itk5 branch. Could you check?
Thanks! Paul
On Fri, Apr 2, 2021 at 2:55 PM Jeff VanOss @.***> wrote:
scoping isnan to use the stdlib version fixes #23 https://github.com/pyushkevich/greedy/issues/23
Is there a better isnon to use 🤷
You can view, comment on, or merge this pull request online at:
https://github.com/pyushkevich/greedy/pull/24 Commit Summary
- use std::isnan
File Changes
- M src/ITKFilters/include/MultiComponentMutualInfoImageMetric.txx https://github.com/pyushkevich/greedy/pull/24/files#diff-567e81aa0072423a9c3de3d57fe76c1e5618a731b93b18318963b56fa6ba6c58 (2)
- M src/ITKFilters/include/MultiComponentNCCImageMetric.txx https://github.com/pyushkevich/greedy/pull/24/files#diff-e8ff850bb001acbbc57e97f17207d6566a49d5af3a177dce1d3c92e1eee94b28 (4)
- M src/MultiImageRegistrationHelper.cxx https://github.com/pyushkevich/greedy/pull/24/files#diff-7dd78cd62a72918c34fb22473597a1582ea9b2c3ada861ae12b5121ba97c0ab1 (4)
- M src/lddmm_data.cxx https://github.com/pyushkevich/greedy/pull/24/files#diff-4f876e3afc1a7e4a9495758f9aac0606149523d88c63d725cfe7b41dfe2cbcdb (4)
Patch Links:
- https://github.com/pyushkevich/greedy/pull/24.patch
- https://github.com/pyushkevich/greedy/pull/24.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pyushkevich/greedy/pull/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJPEW2QOASPMLVVJQGRV6TTGYHKDANCNFSM42JI6E6A .
-- Paul A. Yushkevich, Ph.D. Professor of Radiology Penn Image Computing and Science Laboratory University of Pennsylvania Perelman School of Medicine
It's still broken in the itk5 branch. But changing isnan
to std::isnan
fixes the itk5 branch too
scoping
isnan
to use the stdlib version fixes #23Is there a better
isnan
to use :shrug: