pyushkevich / greedy

Very fast greedy diffeomorphic registration code
GNU General Public License v3.0
62 stars 17 forks source link

use std::isnan #24

Open vanossj opened 3 years ago

vanossj commented 3 years ago

scoping isnan to use the stdlib version fixes #23

Is there a better isnan to use :shrug:

pyushkevich commented 3 years ago

Jeff,

I think this is already fixed in the itk5 branch. Could you check?

Thanks! Paul

On Fri, Apr 2, 2021 at 2:55 PM Jeff VanOss @.***> wrote:

scoping isnan to use the stdlib version fixes #23 https://github.com/pyushkevich/greedy/issues/23

Is there a better isnon to use 🤷

You can view, comment on, or merge this pull request online at:

https://github.com/pyushkevich/greedy/pull/24 Commit Summary

  • use std::isnan

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pyushkevich/greedy/pull/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJPEW2QOASPMLVVJQGRV6TTGYHKDANCNFSM42JI6E6A .

-- Paul A. Yushkevich, Ph.D. Professor of Radiology Penn Image Computing and Science Laboratory University of Pennsylvania Perelman School of Medicine

vanossj commented 3 years ago

It's still broken in the itk5 branch. But changing isnan to std::isnan fixes the itk5 branch too