pyutils / line_profiler

Line-by-line profiling for Python
Other
2.57k stars 118 forks source link

Fix #183 #184

Closed Theelx closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #184 (67d7a9c) into main (d5fbcfb) will decrease coverage by 1.34%. The diff coverage is 21.42%.

:exclamation: Current head 67d7a9c differs from pull request most recent head 70a5002. Consider uploading reports for the commit 70a5002 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/pyutils/line_profiler/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=xIK8nFU3K5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/pyutils/line_profiler/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #184 +/- ## ========================================== - Coverage 50.59% 49.24% -1.35% ========================================== Files 4 4 Lines 253 266 +13 Branches 37 39 +2 ========================================== + Hits 128 131 +3 - Misses 112 121 +9 - Partials 13 14 +1 ``` | [Impacted Files](https://codecov.io/gh/pyutils/line_profiler/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [line\_profiler/line\_profiler.py](https://codecov.io/gh/pyutils/line_profiler/pull/184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bGluZV9wcm9maWxlci9saW5lX3Byb2ZpbGVyLnB5) | `50.26% <21.42%> (-1.99%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pyutils/line_profiler/pull/184?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pyutils/line_profiler/pull/184?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [d5fbcfb...70a5002](https://codecov.io/gh/pyutils/line_profiler/pull/184?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
Erotemic commented 1 year ago

Thanks for debugging this. We should add a test to make sure this regression doesn't happen again (I'll take care of that later).

Theelx commented 1 year ago

Sounds good. I can add the test momentarily.