Brno - Githubissues

pyvec / cz.pycon.org-2016

PyCon in the Czech Republic 2016

https://cz.pycon.org/2016/

MIT License

8 stars 6 forks source link

Brno #116

Closed honzajavorek closed 8 years ago

honzajavorek commented 8 years ago

Added:

Brno guide from @michalkasparek
My guide how to get to Brno
USE-IT map suggestion
Some other tips (accommodation, Czech Republic)

Not in this PR:

Link to the page from menu (preferable label: "Brno")
Mobile version of CSS

Closes https://github.com/pyvec/cz.pycon.org-2016/issues/71

I'm not sure having pyconcz_2016/static_build/ in git is a good idea (it has all the CVS antipatterns in the world: unreadable diffs, merge conflicts, versioned result of compilation, ...), but I'm far from ranting against it at this point.

tricoder42 commented 8 years ago

Yes, static_build shouldn't be there, but the other option is to add build step and distribute packages (eggs, wheels), which is a bit more complicated than simple git-based deployment. Regarding merge, when it happen, simply discard it and run npm run build...

It could be optimized, but as long as it's not very unconvenient, I don't mind.

honzajavorek commented 8 years ago

BTW, regarding the link, I think it can be added as a subsequent PR. If we get this page working without link, we can show it to people and get feedback before actually publishing it.

But it's true there won't be that much room for feedback since I'd like to have this out during Mon the latest 🚀 🕙 😱

honzajavorek commented 8 years ago

@tricoder42 I see readability of the PR diff as the biggest problem of the static build included. I tried to mitigate it by isolating it into its own commit so the reviewer can at least go commit by commit when reading and skip the one with build.