search

pyvec / elsa

Helper module for hosting Frozen-Flask based websites on GitHub pages
Other
29 stars 49 forks source link

Only treat Frozen-Flask warnings as errors, not other warnings #34

Closed hroncok closed 7 years ago

hroncok commented 7 years ago

If all warnings are treated as errors and some underlying code emits a PendingDeprecationWarning or such, the site is unfreezable. This change makes sure we only treat the warnings emitted by Frozn Flask as errors.

hroncok commented 7 years ago

This blocks https://github.com/pyvec/naucse.python.cz/pull/71

encukou commented 7 years ago

Would Frozen-Flask object to having a common superclass for its warnings?

hroncok commented 7 years ago

I got that idea yesterday, but forgot to mention that. I'll send a PR / talk to them.

hroncok commented 7 years ago

https://github.com/Frozen-Flask/Frozen-Flask/pull/73

hroncok commented 7 years ago

Changed upstream, new version released. Amended to use that.

hroncok commented 7 years ago

Also added a test.

encukou commented 7 years ago

Hi, I won't have time for reviews until Monday at earliest. I hope my reviews aren't blocking you.

hroncok commented 7 years ago

No rush :)