search

pyvec / naucse

A server for open course material
Other
2 stars 9 forks source link

Fix a bug when sanitizing `scoped` attribute of style element #25

Closed frenzymadness closed 4 years ago

frenzymadness commented 5 years ago

When sanitizing scoped attribute of <style> element it makes sense to do it before DisallowedAttribute exception is raised (because scoped is not in sets of allowed attributes) and it also makes sense to continue when this attribute is deleted from an element.

I've found this bug because notebook files contains style elements with scoped attibutes.

frenzymadness commented 4 years ago

Ping

encukou commented 4 years ago

Ow, sorry! I missed the notification :(

Do you have a notebook that we could use as a test?

frenzymadness commented 4 years ago

For example this notebook contains a lot of <style scoped> tags.