pyvideo / richard

video indexing site
Other
216 stars 55 forks source link

Add Schema.org VideoObject RDFa metadata #213

Closed westurner closed 10 years ago

westurner commented 10 years ago

Schema.org

TODO:

I don't have a local installation here, so I'm just editing a template for right now.

Please let me know your thoughts?

westurner commented 10 years ago

References:

willkg commented 10 years ago

I see you want to add metadata to the page, but I don't understand why. What does adding the metadata to the page help? What's the purpose for this change?

westurner commented 10 years ago

I see you want to add metadata to the page, but I don't understand why. What does adding the metadata to the page help? What's the purpose for this change?

Adding metadata to the page makes it possible for search engines to index and present "rich snippets" for the videos.

Videos are one of the most common types of results on Google and we want to make sure that your videos get indexed. Today, we're also launching video support for schema.org. Schema.org is a joint effort between Google, Microsoft, Yahoo! and Yandex and is now the recommended way to describe videos on the web. The markup is very simple and can be easily added to most websites.

willkg commented 10 years ago

This looks good. I had a few comments.

Regarding the outstanding questions in your PR description:

  1. <meta> can't be a direct child of <dl>, but that should be easily solved by just tucking it into the <dd>.
  2. pyvideo has lousy copyright/license information for the videos it indexes. I'm not really sure that's a problem we can solve easily partially because I don't really have a clue what the copyright/license information is for many of the videos on the site. I suspect we can make what we're reporting better, though. We should spin that off into a separate issue for now.
  3. pyvideo is doing a lousy job with languages, too. That's something that should get fixed. Once we fix that, then we'd (probably) have correct language codes for things. That should get a separate issue, too.

I don't really understand the PublicationEvent/BroadcastEvent question. Can you explain that a bit more?

Thank you so much for working on this!

westurner commented 10 years ago

I had added an explicit "python" tag and have now removed it, but wonder whether a default python tag for the pyvideo installation would be helpful?

westurner commented 10 years ago

*nest

westurner commented 10 years ago

pyvideo is doing a lousy job with languages, too. That's something that should get fixed. Once we fix that, then we'd (probably) have correct language codes for things. That should get a separate issue, too.

I believe most of the (common?) codes intersect.

westurner commented 10 years ago

I don't really understand the PublicationEvent/BroadcastEvent question. Can you explain that a bit more?

I was looking for a property to express that particular video has a category like 'PyCon 2014'.

I don't know whether http://schema.org/PublicationEvent or http://schema.org/BroadcastEvent would be the appropriate way to markup the category for a particular conference.

I could add the text as a tag. TBH I'm not really sure which properties are most useful.

willkg commented 10 years ago

Sorry about that! Github doesn't notify anyone when there are new commits--only new comments. So I didn't notice these until now.

I don't have time to look at this today, but will try to make time for this in the next week.

westurner commented 10 years ago

No worries! Thanks for your time.

westurner commented 10 years ago

Are there any further concerns?

willkg commented 10 years ago

Sorry about that--I haven't had time to look at this, yet. I'll try to get to it in the next week.

willkg commented 10 years ago

Sorry this took so long to get to. The last few months have been really rough.

I went through all the code changes and they looked good to me. I don't have any outstanding issues.

I pulled the changes, smooshed them into a single commit, rebased against master and re-ran the tests and landed it here:

b3fb08c Add schema.org VideoObject RDFa metadata

Thank you so much for this!

westurner commented 10 years ago

Thanks!

westurner commented 10 years ago

https://github.com/ligershark/webdevchecklist.com/pull/71/files#diff-4794d18d5d5b09b7fc4269a638a9e0dbR110

...

A. Twitter Cards and Facebook OpenGraph could be helpful

B. Sharing widget>?

willkg commented 10 years ago

Those could be interesting. It's worth writing up issues for them.

westurner commented 10 years ago

Test URLs:

westurner commented 10 years ago

BUG: There appears to be a missing slash in the vocab= line.

PR comment here: https://github.com/willkg/richard/commit/b3fb08c#commitcomment-7093151

willkg commented 10 years ago

Instead of commenting on a closed PR which is difficult to track, can you open up a new issue for the problem you found?