pyvideo / richard

video indexing site
Other
216 stars 55 forks source link

Restructure settings files (don't use settings_local.py) #216

Closed treyhunner closed 10 years ago

treyhunner commented 10 years ago

Ideas:

paulcollinsiii commented 10 years ago

So originally we had a discussion about how django-configurations requires poking around in manage.py and wsgi.py to work. I didn't like this idea because I was under the impression that manage.py was going away at some point in the future. At this point I don't know how I got that impression since I've been unable to find any mailing list posts about it or any notification in the release_notes for the development version of django.

At this point I'd say django-configurations is cleaner than even the "One True Way" because layering module imports in your mind gets messy once you've got

my_project
|- manage.py
|- my_project
|  |- settings
|  |  |- base.py
|  |  |- local_dev.py
|  |  |- test_unit.py 
|  |  |- test.py
|  |  |- production.py

I can put together a PR for this soon

willkg commented 10 years ago

I'm pretty sure we'll have base.py, test.py and local_dev.py. I don't think I'm going to put the production or staging ones in richard because richard is general and not pyvideo-specific (though I waffle about that periodically). That seems doable for the 2 Scoops way plus that means we have one less dependency.

So at the moment, I'm leaning towards 2 Scoops way.

paulcollinsiii commented 10 years ago

with the recent switch to django-configurations, I think this issue can be closed

willkg commented 10 years ago

@treyhunner Good catch. Thank you!