search

pyvideo / richard

video indexing site
Other
216 stars 55 forks source link

images in summary/description should be constrained #250

Closed willkg closed 9 years ago

willkg commented 10 years ago

If someone has an image in the summary/description, then it extends as much as it wants to which is kind of dumb looking.

We should constrain that.

This probably requires us to figure out how Markdown is building images so we can effectively constrain "too large" images without affecting smaller ones.

Example here (while it's still here):

http://pyvideo.org/video/2723/wcsaxes-a-framework-for-plotting-astronomical-an

squiddy commented 9 years ago

Setting max-width: 100% on images in the summary/description could work. Didn't check it against browsers other than chrome though. Can do that later.

willkg commented 9 years ago

Works in Firefox nightly, too.

However, the HTML sucks there. We should give the div the description is in an id so that we can do a CSS rule like this:

#description img {
   max-width: 100%;
}
squiddy commented 9 years ago

Seems github didn't pick up the Fixes in my commit message, I was under the impression they support that. Anyway, closing this one.