search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

Fix of encode called on bytes object #119

Closed skrchnavy closed 6 years ago

skrchnavy commented 6 years ago

this is PR to fix PR #59 in gpib module and not in generic session when reader shall return bytes and not string. similar approach was provided in #70 (author @DavidFabijan ) It shall fix these issues: #69, #73,

Problem in gpib could be not solved perfectly, but is not spread across other session types.

This invalidates PRs: #66 (author @herm ) , #70 (@DavidFabijan ), #86 (@marekp0). All could be closed.

skrchnavy commented 6 years ago

@MatthieuDartiailh _read operation is candidate for small refactoring, I have idea to use it also in TCPIP SOCKET session. So for now we shall do this small step.

MatthieuDartiailh commented 6 years ago

This looks good to me. Should I merge now ?

skrchnavy commented 6 years ago

If not further comments, please merge

MatthieuDartiailh commented 6 years ago

Merging. Closes #70, #66, #86, #59, #69, #73

bors r+

bors[bot] commented 6 years ago

Build succeeded