search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

Attempt to fix an issue in rpc in which a select timeout cause a EOFError #130

Closed MatthieuDartiailh closed 6 years ago

MatthieuDartiailh commented 6 years ago

The basic idea is that compared to the old version (pre PR 67), we can now get an empty read_data because the select timed out, which by itself may no mean anything, and we need to wait to see if we get a real timeout rather than complaining about EOFError early.

@svanan77 could you review and test. Hopefully this should fix https://github.com/pyvisa/pyvisa/issues/319 and given the nature of the issue, it is possible I could not easily reproduce locally.

MatthieuDartiailh commented 6 years ago

I removed a small of the debug that I fear may be a bit costly to keep. This is ready to merge as far as I am concerned since this is more correct than the previous version even if it does not appear to fix https://github.com/pyvisa/pyvisa/issues/319 in all cases. Any review welcome, and otherwise I will merge sometimes next week.

MatthieuDartiailh commented 6 years ago

bors r+

bors[bot] commented 6 years ago

Build succeeded