pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

Add missing operations to highlevel.py #139

Closed aholtzma closed 6 years ago

aholtzma commented 6 years ago

This change plumbs in the missing read_stb() from tcpip.py to highlevel.py.

MatthieuDartiailh commented 6 years ago

Could you also add it to sessions.py to return return StatusCode.error_nonsupported_operation just like for other methods that may not be implemented by all backends ?

MatthieuDartiailh commented 6 years ago

ping @aholtzma

MatthieuDartiailh commented 6 years ago

@aholtzma I took the liberty to complete your work and also fix some related issues in tcpip. If anybody can test this on real instruments (I won't have access to any for a week), I would appreciate it.

MatthieuDartiailh commented 6 years ago

I tested this and it seems to work. I will merge. Since this was from my point of view the last release blocker, I would appreciate if some people could test before I cut the release. @greyltc @skrchnavy @tivek

bors r+

bors[bot] commented 6 years ago

Build succeeded

tivek commented 6 years ago

I am sorry for my late reply, I was on the road without the equipment. I can reserve time for later this week to test the new commit.

MatthieuDartiailh commented 6 years ago

That would be awesome @tivek. Thanks