search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
288 stars 124 forks source link

sessions: pass the timeout value when creating a USB interface. #167

Closed MatthieuDartiailh closed 5 years ago

MatthieuDartiailh commented 6 years ago

Proper fix for #166

@mgubser could you please review and test.

mgubser commented 6 years ago

I reviewd it, made another fix and sent you another pull request since I don't have write access to this repo.

MatthieuDartiailh commented 5 years ago

@mgubser thanks for catching this actually I got confused (once again) by the purpose of timeout on session. Hopefully this time I made the explanation clear enough (and got it right). The interface timeout should always be an integer and in ms which is why I reassign the default value after creating the interface rather than simply converting to int as you suggested in #168 . Please check this fixes your issue.

mgubser commented 5 years ago

@MatthieuDartiailh This looks ok now. I don't see any related errors anymore. Thanks for taking on this issue.

MatthieuDartiailh commented 5 years ago

Thanks @mgubser. I will update the release notes and merge sometime this week.

MatthieuDartiailh commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build succeeded