search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

gpib.py: VI_ATTR_SEND_END_EN should call IbcEOT, not the unimplemented IbcEndBitIsNormal #196

Closed dirkenstein closed 4 years ago

dirkenstein commented 5 years ago

This issue may be specific to using pyvisa-py with linux-gpib 4.2.0 but may not happen with NI 488.2 libararies.

Basically linux-gpib does not implement IbcEndBitIsNormal being set to 0.

However, according to the NI-488.2 documentation, IbcEndBitIsNormal seems to relate to receiving EOI not sending it.

I believe VI_ATTR_SEND_END_EN should use IbcEOT (0x4) constant for setting send EOI or not. This is both foribconfig() and ibask().

MatthieuDartiailh commented 5 years ago

Thanks for report. If you can make a PR with those changes it would be great ! I will try to look into it but I am not very familiar with linux-gpib it may take me some time.

As a side note, if you are familiar with low-level gpib operation, I would greatly appreciate if you have time to review https://github.com/pyvisa/pyvisa-py/pull/194 that aims at improving GPIB support in Pyvisa-py.

MatthieuDartiailh commented 4 years ago

Closed by #194