search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

Removed SEND_END_EN from variable parameters #200

Closed dirkenstein closed 5 years ago

dirkenstein commented 5 years ago

This was hard to track down- adding VI_ATTR_SEND_END_EN to self.attrs disables attribute setting using_set_attribute() as it's now just a variable.

You can't set defaults this way except for attributes that are not implemented in _set_attribute().

MatthieuDartiailh commented 5 years ago

So sorry for this ! I just copy pasted what was done on other resource because I realized we were missing termination characters. As I said earlier I need to look at the VISA spec to clean up the attributes. I am pretty sure that we cannot share all of them between INSTR and INTFC. Thanks for tracking this down.

dirkenstein commented 5 years ago

Don't panic- my application works now on both Keysight VISA and pyvisa-py with linux-gpib-4.2.0. The only difference is now down to the Agilent 82357 not supporting iblines() correctly on linux-gpib, so list_resources() doesn't allow auto-discovery. Nothing to do with pyvisa or pyvisa-py.

Dirk

On Mon, Jul 22, 2019 at 1:17 PM Matthieu Dartiailh notifications@github.com wrote:

Merged #200 https://github.com/pyvisa/pyvisa-py/pull/200 into gpib-interface.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pyvisa/pyvisa-py/pull/200?email_source=notifications&email_token=AJBR63IVIWPQARPHC4QEKDTQAWQMZA5CNFSM4IFX3UQ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOST6SODQ#event-2499618574, or mute the thread https://github.com/notifications/unsubscribe-auth/AJBR63IRSVU3B6SPQT5DDWDQAWQMZANCNFSM4IFX3UQQ .

MatthieuDartiailh commented 5 years ago

WOW that's great to hear @dirkenstein ! Thanks a lot for taking the time to debug this. I will try to clean up the attribute mess and push this into the release.