pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
288 stars 124 forks source link

fix(logging): Fix logging error and add missing argument #315

Closed lovetheguitar closed 2 years ago

lovetheguitar commented 2 years ago

When depending on the logging class, to format the logging message, arguments need to get passed separately, unlike with direct string formatting where a tuple with all arguments is expected.

codecov-commenter commented 2 years ago

Codecov Report

Merging #315 (546b347) into main (91e3475) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   22.04%   22.04%           
=======================================
  Files          20       20           
  Lines        2595     2595           
  Branches      394      394           
=======================================
  Hits          572      572           
+ Misses       2016     2015    -1     
- Partials        7        8    +1     
Flag Coverage Δ
unittests 22.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyvisa_py/gpib.py 5.40% <0.00%> (ø)
pyvisa_py/sessions.py 40.50% <ø> (ø)
pyvisa_py/protocols/rpc.py 23.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91e3475...546b347. Read the comment docs.

MatthieuDartiailh commented 2 years ago

Thanks for your patch !

Can you run black to appease the CIs and then I will merge ?

lovetheguitar commented 2 years ago

Very welcome. Thanks for the good work. Formatting done ✔️ Sorry for not running it before, I could not imagine it would reformat something with so little change. 😄

MatthieuDartiailh commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Timed out.