Open adriengcql opened 2 years ago
WHAT Attempting a failing RPC connection throws OSError: [WinError 10038] An operation was attempted on something that is not a socket
OSError: [WinError 10038] An operation was attempted on something that is not a socket
EXPECTED It should throw RPCError: can't connect to server (from this line
RPCError: can't connect to server
WHY See protocols.rpc._connect: in case there is an Exception, sock.setblocking(1) is called after sock.close()
sock.setblocking(1)
sock.close()
Indeed that looks like a problem. Can you make a PR ?
WHAT Attempting a failing RPC connection throws
OSError: [WinError 10038] An operation was attempted on something that is not a socket
EXPECTED It should throw
RPCError: can't connect to server
(from this lineWHY See protocols.rpc._connect: in case there is an Exception,
sock.setblocking(1)
is called aftersock.close()